Skip to content

[MAPPS-2235] fix: Splunk app inspect issue fix #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

[MAPPS-2235] fix: Splunk app inspect issue fix #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3093024
[MAPPS-2235] fix: TA splunk app inspect issue fix
munna-shaik-s1 Jul 4, 2024
afa2a9d
[MAPPS-2235] fix: TA splunk app ui updation
munna-shaik-s1 Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions TA_dataset/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# TA_dataset
This add-on integrates with [DataSet](https://www.dataset.com) and [Singularity Data Lake](https://www.sentinelone.com/platform/xdr-ingestion) by [SentinelOne](https://www.sentinelone.com).


# Binary File Declaration
lib/charset_normalizer/md.cpython-38-x86_64-linux-gnu.so: This binary file is provided along with charset_normalizer module and source code for the same can be found at https://pypi.org/project/charset-normalizer/
lib/charset_normalizer/md__mypyc.cpython-38-x86_64-linux-gnu.so: This binary file is provided along with charset_normalizer module and source code for the same can be found at https://pypi.org/project/charset-normalizer/


For more information, see the [GitHub](https://github.com/scalyr/dataset-addon-for-splunk) repository.
##### Note
This add-on was built with the [Splunk Add-on UCC framework](https://splunk.github.io/addonfactory-ucc-generator/).
Expand Down
4 changes: 2 additions & 2 deletions e2e/global.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ setup('login and create account', async ({ page }) => {
await locAddDialog.click();

// Setup locators
const locAccount = page.locator('div').filter({ hasText: /^\*?Account Name \*Enter a unique name for this account\.$/ }).locator('[data-test="textbox"]')
const locUrl = page.locator('div').filter({ hasText: /^\*?URL \*Enter DataSet URL\.$/ }).locator('[data-test="textbox"]')
const locAccount = page.locator('div').filter({ hasText: /^\*?Account NameEnter a unique name for this account\.$/ }).locator('[data-test="textbox"]')
const locUrl = page.locator('div').filter({ hasText: /^\*?URLEnter DataSet URL\.$/ }).locator('[data-test="textbox"]')
const locReadKey = page.locator('[data-test="body"] form div').filter({ hasText: 'SDL Read Access Key (Legacy)Required (if no AuthN token provided) to enable' }).locator('[data-test="textbox"]');
const locWriteKey = page.locator('[data-test="body"] form div').filter({ hasText: 'SDL Write Access Key (Legacy)Required (if no AuthN token provided) to enable alert action.' }).locator('[data-test="textbox"]');

Expand Down
6 changes: 3 additions & 3 deletions e2e/inputs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test('New Input - DataSet Query', async ({ page }) => {
await page.locator('div').filter({ hasText: /^\*?ColumnsIf left blank, all columns are returned\.$/ }).locator('[data-test="textbox"]').fill("")
await page.locator('form div').filter({ hasText: /^\*?Max CountSpecifies the maximum number of records to return. If left blank, the d/ }).locator('[data-test="textbox"]').fill("13")

await page.getByLabel("Select a value").click();
await page.getByLabel("Select...").click();
await page.locator('[data-test="option"]').first().click();

await page.screenshot({ path: 'playwright-screenshots/page-inputs-query-01-filled-form.png', fullPage: true });
Expand All @@ -50,7 +50,7 @@ test('New Input - DataSet PowerQuery', async ({ page }) => {
await page.locator('form div').filter({ hasText: /^\*?End TimeIf left blank, present time at query execution is used. If defined, use/ }).locator('[data-test="textbox"]').fill("1m")
await page.locator('form div').filter({ hasText: /^\*?DataSet PowerQuery String/ }).locator('[data-test="textbox"]').fill("serverHost=* | group count=count() by tag")

await page.getByLabel("Select a value").click();
await page.getByLabel("Select...").click();
await page.locator('[data-test="option"]').first().click();

await page.screenshot({ path: 'playwright-screenshots/page-inputs-powerquery-01-filled-form.png', fullPage: true });
Expand All @@ -77,7 +77,7 @@ test('New Input - DataSet Alerts', async ({ page }) => {
await page.locator('div').filter({ hasText: /^\*?IntervalTime interval of input in seconds\.$/ }).locator('[data-test="textbox"]').fill("20")
await page.locator('form div').filter({ hasText: /^\*?Start TimeRelative time to query back. Use short form relative time, e.g.: 24h/ }).locator('[data-test="textbox"]').fill("60m")

await page.getByLabel("Select a value").click();
await page.getByLabel("Select...").click();
await page.locator('[data-test="option"]').first().click();

await page.screenshot({ path: 'playwright-screenshots/page-inputs-alerts-01-filled-form.png', fullPage: true });
Expand Down
78 changes: 12 additions & 66 deletions globalConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"displayName": "Singularity Data Lake Add-On for Splunk",
"version": "2.0.71-SNAPSHOT",
"restRoot": "TA_dataset",
"schemaVersion": "0.0.3"
"schemaVersion": "0.0.7",
"_uccVersion": "5.47.0"
},
"pages": {
"configuration": {
Expand Down Expand Up @@ -34,7 +35,7 @@
"entity": [
{
"field": "name",
"label": "Account Name *",
"label": "Account Name",
"type": "text",
"required": true,
"help": "Enter a unique name for this account.",
Expand All @@ -54,7 +55,7 @@
},
{
"field": "url",
"label": "URL *",
"label": "URL",
"type": "text",
"help": "Enter DataSet URL.",
"required": true,
Expand All @@ -69,7 +70,7 @@
},
{
"field": "tenant",
"label": "Run On *",
"label": "Run On",
"type": "singleSelect",
"options": {
"disableSearch": true,
Expand Down Expand Up @@ -186,41 +187,7 @@
]
},
{
"name": "logging",
"title": "Logging",
"entity": [
{
"field": "loglevel",
"label": "Log level",
"type": "singleSelect",
"options": {
"disableSearch": true,
"autoCompleteFields": [
{
"label": "DEBUG",
"value": "DEBUG"
},
{
"label": "INFO",
"value": "INFO"
},
{
"label": "WARNING",
"value": "WARNING"
},
{
"label": "ERROR",
"value": "ERROR"
},
{
"label": "CRITICAL",
"value": "CRITICAL"
}
]
},
"defaultValue": "INFO"
}
]
"type": "loggingTab"
},
{
"name": "proxy",
Expand Down Expand Up @@ -398,18 +365,11 @@
}
},
{
"type": "interval",
"field": "interval",
"label": "Interval",
"type": "text",
"required": true,
"help": "Time interval of input in seconds.",
"validators": [
{
"type": "regex",
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
"errorMsg": "Interval must be an integer."
}
]
"required": true
},
{
"field": "index",
Expand Down Expand Up @@ -561,18 +521,11 @@
}
},
{
"type": "interval",
"field": "interval",
"label": "Interval",
"type": "text",
"required": true,
"help": "Time interval of input in seconds.",
"validators": [
{
"type": "regex",
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
"errorMsg": "Interval must be an integer."
}
]
"required": true
},
{
"field": "index",
Expand Down Expand Up @@ -687,18 +640,11 @@
}
},
{
"type": "interval",
"field": "interval",
"label": "Interval",
"type": "text",
"required": true,
"help": "Time interval of input in seconds.",
"validators": [
{
"type": "regex",
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
"errorMsg": "Interval must be an integer."
}
]
"required": true
},
{
"field": "index",
Expand Down
2 changes: 1 addition & 1 deletion requirements-pack.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ cython<3.0.0; python_version <= '3.8'
# we use 3.8 for development
pip==23.2.1; python_version <= '3.8'
pyyaml==6.0.1; python_version <= '3.8'
splunk-add-on-ucc-framework==5.13.2; python_version <= '3.8'
splunk-add-on-ucc-framework==5.47.0; python_version <= '3.8'
splunk-appinspect==2.37.2; python_version <= '3.8'
wheel==0.41.0; python_version <= '3.8'