Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-424: Refactor Veeam summary page #704

Merged

Conversation

ChengYanJin
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Dec 12, 2023

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 12, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-424 contains:

  • 2.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.1

Please check the Fix Version/s of ZKUI-424, or the target
branch of this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (84a6cfe) 60.31% compared to head (4ca6346) 60.24%.
Report is 2 commits behind head on development/2.2.

Files Patch % Lines
src/react/ui-elements/Veeam/VeeamSteps.tsx 0.00% 2 Missing ⚠️
src/react/ui-elements/Veeam/VeeamSummary.tsx 86.66% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/2.2     #704      +/-   ##
===================================================
- Coverage            60.31%   60.24%   -0.08%     
===================================================
  Files                  222      222              
  Lines                10690    10697       +7     
  Branches              3119     3119              
===================================================
- Hits                  6448     6444       -4     
- Misses                4223     4234      +11     
  Partials                19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bert-e
Copy link
Contributor

bert-e commented Dec 13, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Dec 14, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin marked this pull request as ready for review December 14, 2023 15:28
@ChengYanJin ChengYanJin force-pushed the improvement/ZKUI-424-polish-veeam-summary-page branch from 4ca6346 to 257a93c Compare December 14, 2023 17:54
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!!
its-perfect-klaus-hargreeves-gif

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 15, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 15, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-424.

Goodbye chengyanjin.

@bert-e bert-e merged commit 44a970d into development/2.2 Dec 15, 2023
9 checks passed
@bert-e bert-e deleted the improvement/ZKUI-424-polish-veeam-summary-page branch December 15, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants