-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Veeam non-immutable policy support #702
Add Veeam non-immutable policy support #702
Conversation
Hello hervedombya,My role is to assist you with the merge of this Status report is not available. |
2b6fc1a
to
d8d4560
Compare
src/js/mutations.test.ts
Outdated
@@ -41,7 +42,7 @@ const tagSet = [ | |||
Value: 'Veeam 12', | |||
}, | |||
]; | |||
const veeamPolicyName = `${VEEAM_IMMUTABLE_POLICY_NAME}-${bucketName}`; | |||
export const veeamPolicyName = `${VEEAM_IMMUTABLE_POLICY_NAME}-${bucketName}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why is this export necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed f7a6e20
Add tests Fix variable declaration in mutations.test.ts
5e67258
to
f7a6e20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/2.2 #702 +/- ##
===================================================
+ Coverage 60.31% 60.36% +0.04%
===================================================
Files 222 222
Lines 10690 10695 +5
Branches 3119 3122 +3
===================================================
+ Hits 6448 6456 +8
+ Misses 4223 4220 -3
Partials 19 19 ☔ View full report in Codecov by Sentry. |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZKUI-427. Goodbye hervedombya. |
No description provided.