Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Veeam non-immutable policy support #702

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

hervedombya
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Dec 11, 2023

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 11, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-427 contains:

  • 2.2.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.1

Please check the Fix Version/s of ZKUI-427, or the target
branch of this pull request.

@hervedombya hervedombya force-pushed the feature/ZKUI-427-veeam-non-immutable-policy branch from 2b6fc1a to d8d4560 Compare December 11, 2023 16:03
@hervedombya hervedombya marked this pull request as ready for review December 11, 2023 16:07
@@ -41,7 +42,7 @@ const tagSet = [
Value: 'Veeam 12',
},
];
const veeamPolicyName = `${VEEAM_IMMUTABLE_POLICY_NAME}-${bucketName}`;
export const veeamPolicyName = `${VEEAM_IMMUTABLE_POLICY_NAME}-${bucketName}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why is this export necessary ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed f7a6e20

Add tests

Fix variable declaration in mutations.test.ts
@hervedombya hervedombya force-pushed the feature/ZKUI-427-veeam-non-immutable-policy branch from 5e67258 to f7a6e20 Compare December 11, 2023 16:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84a6cfe) 60.31% compared to head (f7a6e20) 60.36%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/2.2     #702      +/-   ##
===================================================
+ Coverage            60.31%   60.36%   +0.04%     
===================================================
  Files                  222      222              
  Lines                10690    10695       +5     
  Branches              3119     3122       +3     
===================================================
+ Hits                  6448     6456       +8     
+ Misses                4223     4220       -3     
  Partials                19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bert-e
Copy link
Contributor

bert-e commented Dec 11, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-427 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.1

Please check the Fix Version/s of ZKUI-427, or the target
branch of this pull request.

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 11, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 11, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-427.

Goodbye hervedombya.

@bert-e bert-e merged commit f7a6e20 into development/2.2 Dec 11, 2023
15 checks passed
@bert-e bert-e deleted the feature/ZKUI-427-veeam-non-immutable-policy branch December 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants