Skip to content

[PATCH] Revert block device status condition on PKNAME #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezekiel-alexrod merged 1 commit into from
May 7, 2025
Merged

[PATCH] Revert block device status condition on PKNAME #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pkg/implementation/physicaldrivegetter/rhel8.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,7 @@ func (r *RHEL8) physicalDriveStatus(device *BlockDevice) (physicaldrive.PDStatus
return physicaldrive.PDStatusFailed, "", nil
}

if device.MountPoint != "" ||
device.FileSystemType != "" ||
device.PartitionType != "" ||
device.ParentKernelName != "" {
if device.MountPoint != "" || device.FileSystemType != "" || device.PartitionType != "" {
return physicaldrive.PDStatusUsed, reason, nil
}

Expand Down
5 changes: 1 addition & 4 deletions pkg/implementation/physicaldrivegetter/ssacli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,7 @@ func parseSlotInfo(pd *physicaldrive.PhysicalDrive, key, value string) {
// If the device is mounted or has a filesystem type, it is considered used.
// Otherwise, it is considered unassigned good.
func isBlockDeviceUsed(device *BlockDevice) bool {
if device.MountPoint != "" ||
device.FileSystemType != "" ||
device.PartitionType != "" ||
device.ParentKernelName != "" {
if device.MountPoint != "" || device.FileSystemType != "" || device.PartitionType != "" {
return true
}

Expand Down