Skip to content

[MINOR] Handle PKNAME colum of lsblk to set the status of the parent disk of partitions#18

Merged
ezekiel-alexrod merged 1 commit intomainfrom
bugfix/handle-pkname
May 7, 2025
Merged

[MINOR] Handle PKNAME colum of lsblk to set the status of the parent disk of partitions#18
ezekiel-alexrod merged 1 commit intomainfrom
bugfix/handle-pkname

Conversation

@ezekiel-alexrod
Copy link
Copy Markdown
Contributor

No description provided.

@ezekiel-alexrod ezekiel-alexrod requested a review from a team as a code owner May 7, 2025 07:24
@ezekiel-alexrod ezekiel-alexrod force-pushed the bugfix/handle-pkname branch from 835b915 to 9b4f700 Compare May 7, 2025 07:44
@ezekiel-alexrod ezekiel-alexrod merged commit f9cbe47 into main May 7, 2025
3 checks passed
@ezekiel-alexrod ezekiel-alexrod deleted the bugfix/handle-pkname branch May 7, 2025 08:01
if device.MountPoint != "" ||
device.FileSystemType != "" ||
device.PartitionType != "" ||
device.ParentKernelName != "" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree on this one, a partition would have the ParentKernelName to set but it does not mean this partition is actually used

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants