AbortMPU cleanup - revisited

[williamlardier]

Relates to https://scality.atlassian.net/wiki/spaces/OS/pages/3258220958/Retriable+CompleteMultipartUpload

See ticket & commits for context

Issue: CLDSRV-669

Following this PR, we will fix the behavior of the CompleteMPU API to avoid promoting wrongly s3 objects if not all parts are valid. This might not be feasible because we want to be unified with S3C, that is not 100% standard with MPU management, as we can abort after a complete officially.

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-669 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.8.54

• 9.0.19

• 9.1.0

Please check the Fix Version/s of CLDSRV-669, or the target
branch of this pull request.

[codecov]

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.25%. Comparing base (c47dff0) to head (f70c06a).
Report is 5 commits behind head on development/8.8.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/apiUtils/object/abortMultipartUpload.js	97.91%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/apiUtils/object/abortMultipartUpload.js	94.73% <97.91%> (+9.92%)	⬆️

... and 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/8.8    #5854      +/-   ##
===================================================
+ Coverage            65.08%   65.25%   +0.16%     
===================================================
  Files                  188      188              
  Lines                11948    11983      +35     
===================================================
+ Hits                  7776     7819      +43     
+ Misses                4172     4164       -8     

Flag	Coverage Δ
unit	65.25% <97.91%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[williamlardier]

Will need further tests to ensure this works file - we do not officially have a way to list all versions of just one object

[williamlardier]

Test done, it's working well. Example:

{
    "CommonPrefixes": [],
    "Versions": [
        {
            "key": "bug-test-bda30555",
            "value": {
                "Size": 1048576,
                "ETag": "3eaf2c9512f76a55da265ad51ac21393-1",
                "VersionId": "98248542529027999999RG00001",
                "IsDeleteMarker": false,
                "LastModified": "2025-07-02T11:57:50.972Z",
                "Owner": {
                    "DisplayName": "acc",
                    "ID": "5874c85ff66d0ede3bd6e8fe9610f0640d1700a4607f8b7e414503fbd2cb03de"
                },
                "StorageClass": "STANDARD"
            }
        },
        {
            "key": "bug-test-bda30555",
            "value": {
                "Size": 1048576,
                "ETag": "3eaf2c9512f76a55da265ad51ac21393-1",
                "VersionId": "98248542540139999999RG00001",
                "IsDeleteMarker": false,
                "LastModified": "2025-07-02T11:57:39.857Z",
                "Owner": {
                    "DisplayName": "acc",
                    "ID": "5874c85ff66d0ede3bd6e8fe9610f0640d1700a4607f8b7e414503fbd2cb03de"
                },
                "StorageClass": "STANDARD"
            }
        }
    ],
    "IsTruncated": false
}

(while the same key with suffix exists)

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-669 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.8.55

• 9.0.20

• 9.1.0

Please check the Fix Version/s of CLDSRV-669, or the target
branch of this pull request.