-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check large objects before replication #2558
base: development/8.7
Are you sure you want to change the base?
Check large objects before replication #2558
Conversation
Hello killiang,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.7 #2558 +/- ##
===================================================
+ Coverage 69.67% 69.77% +0.10%
===================================================
Files 194 194
Lines 12819 12919 +100
===================================================
+ Hits 8931 9014 +83
- Misses 3878 3895 +17
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Issue: BB-566
a458861
to
e4f5d49
Compare
@@ -73,6 +73,7 @@ const joiSchema = joi.object({ | |||
minMPUSizeMB: joi.number().greater(0).default(20), | |||
probeServer: probeServerJoi.default(), | |||
circuitBreaker: joi.object().optional(), | |||
sourceCheckIfSizeGreaterThanMB: joi.number().positive().default(100), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be a good occasion to review this option:
- can we find a better name (maxObjectSize ?)
- this option is weird, as it breaks crr semantics: what is the purpose of this option? Is it really used? Is there a matching option in cloudserver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, This option simply adds a double check before repushing the object to replication, if an object is so large it takes time to replicate to avoid sending multiple times the same object for replication
We can probably find a better name for it though..
Why do you think it breaks crr sementic ? I don't know if it's really used but there is a default value so I guess it is no ?
}), | ||
], done); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have tests verifying that "large" objects are not replicated...
e4f5d49
to
ae001e3
Compare
Issue: BB-566