Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataMoverTopic not required anymore and defaults to empty string #2554

Open
wants to merge 2 commits into
base: improvement/BB-514-handle-lifecycle-rules
Choose a base branch
from

Conversation

KillianG
Copy link
Contributor

Do not create a consumer if no topic provided

Issue: BB-565

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2024

Incorrect fix version

The Fix Version/s in issue BB-565 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.0

Please check the Fix Version/s of BB-565, or the target
branch of this pull request.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.44%. Comparing base (45393de) to head (a3d8bf8).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...tensions/replication/ReplicationConfigValidator.js 60.00% <ø> (ø)
...sions/replication/queueProcessor/QueueProcessor.js 72.96% <100.00%> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.13% <ø> (-0.02%) ⬇️
Ingestion 69.24% <ø> (+0.53%) ⬆️
Lifecycle 74.91% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <100.00%> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                              Coverage Diff                              @@
##           improvement/BB-514-handle-lifecycle-rules    #2554      +/-   ##
=============================================================================
+ Coverage                                      69.41%   69.44%   +0.03%     
=============================================================================
  Files                                            194      194              
  Lines                                          12792    12792              
=============================================================================
+ Hits                                            8879     8884       +5     
+ Misses                                          3903     3898       -5     
  Partials                                          10       10              
Flag Coverage Δ
api:retry 9.67% <0.00%> (ø)
api:routes 9.57% <0.00%> (ø)
bucket-scanner 85.76% <ø> (ø)
ingestion 12.52% <0.00%> (+0.04%) ⬆️
lib 7.57% <0.00%> (ø)
lifecycle 19.39% <0.00%> (ø)
notification 0.88% <0.00%> (ø)
replication 18.97% <100.00%> (ø)
unit 43.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG KillianG force-pushed the improvement/BB-565-create-consumer-conditionally branch from 48bbfca to 62ece50 Compare October 15, 2024 12:04
@KillianG KillianG changed the base branch from development/8.7 to improvement/BB-514-handle-lifecycle-rules October 15, 2024 12:05
@scality scality deleted a comment from bert-e Oct 15, 2024
@KillianG KillianG force-pushed the improvement/BB-565-create-consumer-conditionally branch from 62ece50 to a3d8bf8 Compare October 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants