fixup post review

scality · Oct 7, 2024 · 2f55014 · 2f55014
1 parent be82286
commit 2f55014
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/monitoring/mongodb/alerts.test.yaml b/monitoring/mongodb/alerts.test.yaml
@@ -345,6 +345,10 @@ tests:
         values: 2x10
       - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-1", member_state="SECONDARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-2.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
         values: 2x10
+      - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-2", member_state="PRIMARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-2.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
+        values: 1x10
+      - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-2", member_state="SECONDARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-1.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
+        values: 2x10
 
     alert_rule_test:
       - alertname: MongoDbRSNotSynced
@@ -353,6 +357,7 @@ tests:
           - exp_labels:
               severity: warning
               rs_nm: data-db-mongodb-sharded-shard-0
+              pod: data-db-mongodb-sharded-shard0-data-2
             exp_annotations:
               description: "MongoDB replica set `data-db-mongodb-sharded-shard-0` is not in the expected state. It currently has `1` SECONDARY members instead of the expected number. Please ensure that all instances are running properly."
               summary: MongoDB replica set out of sync
diff --git a/monitoring/mongodb/alerts.yaml b/monitoring/mongodb/alerts.yaml
@@ -183,7 +183,7 @@ groups:
 
   - alert: MongoDbRSNotSynced
     expr: |
-      count by (rs_nm, pod) (mongodb_rs_members_state{namespace="${namespace}", pod=~"${service}.*", member_state="SECONDARY", rs_state="1"}) != 0
+      count by (rs_nm, pod) (mongodb_rs_members_state{namespace="${namespace}", pod=~"${service}.*", member_state="SECONDARY", rs_state="1"}) != (${replicas} - 1)
     for: 10m
     labels:
       severity: warning