Fixes for cloudserver unification #2373

francoisferrand · 2025-05-02T07:57:30Z

accept lifecycle config only if all rules are supported
return arsenal error of same type when available
Fix crash on buckets created with 7.70 branch
Fix validation of unsupported rules
Fix compute ContentLength from location

Metadata (the component) does return Arsenal errors but not as an instance of the Arsenal errors class. We should keep the same error type instead of returning an internal error. Issue: ARSN-490

Issue: ARSN-490

The validation is more strict, to explicitely reject non-supported rules. Issue: ARSN-490

The length cannot be computed when some data locations do not have a size, in which case the function must return `undefined` instead of possibly reporting any value. Issue: ARSN-490

bert-e · 2025-05-02T07:57:34Z

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-05-02T07:57:41Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

codecov · 2025-05-02T08:03:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (e14f533) to head (b483aef).

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2373      +/-   ##
===================================================
+ Coverage            69.91%   70.05%   +0.13%     
===================================================
  Files                  218      218              
  Lines                17440    17443       +3     
  Branches              3592     3585       -7     
===================================================
+ Hits                 12194    12219      +25     
+ Misses                5242     5220      -22     
  Partials                 4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638

williamlardier

Some minor comments, not blocking

williamlardier · 2025-05-02T09:23:26Z

lib/models/LifecycleConfiguration.ts

+            const msg = 'lifecycle action not implemented';
+            const error = errorInstances.NotImplemented.customizeDescription(msg);
+            return { error };


Suggested change

const msg = 'lifecycle action not implemented';

const error = errorInstances.NotImplemented.customizeDescription(msg);

return { error };

return {

error: errorInstances.NotImplemented

.customizeDescription('lifecycle action not implemented');

};

williamlardier · 2025-05-02T13:50:16Z

lib/s3routes/routesUtils.ts

+ * @param err - Error to convert
+ * @returns ArsenalError instance
+ */
+export function toArsenalError(err: ArsenalError | Error): ArsenalError {


Maybe a candidate for lib/errorUtils.ts? Or a static member of ArsenalError?

williamlardier · 2025-05-02T14:01:49Z

lib/models/LifecycleConfiguration.ts

@@ -89,11 +88,24 @@ export type LifecycleConfigurationMetadata = {
    rules: Rule[],
 };

+export type XMLRule = {


To differentiate between the XMLRule for replication, shall we use a more specific name?

Suggested change

export type XMLRule = {

export type XMLLifecycleRule = {

... and change the replication rule

williamlardier · 2025-05-02T14:02:41Z

tests/unit/models/LifecycleConfiguration.spec.js

+        assert.deepStrictEqual(result, [
+            'Expiration',
+            'NoncurrentVersionTransitions',
+            'Transition'


Suggested change

'Transition'

'Transition',

esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638

jonathan-gramain · 2025-05-06T19:01:57Z

lib/models/LifecycleConfiguration.ts

+                return { ...actionsObj, error };
+            }
+
+            actionsObj.actions.push({ actionName: `${action}` });


Do we use ${...} to copy the string? I don't think it's needed since we don't modify the contents of action, and strings are immutable anyways.

benzekrimaha · 2025-05-07T08:05:56Z

lib/models/LifecycleConfiguration.ts

        this._ruleIDs = [];
        this._tagKeys = [];
        this._config = {};
    }

+    // Memoize the supported lifecycle rules to avoid recalculating them


Suggested change

// Memoize the supported lifecycle rules to avoid recalculating them

// Memorize the supported lifecycle rules to avoid recalculating them

No typo, Memoization is the right term here

Kerkesni and others added 5 commits April 29, 2025 13:19

accept lifecycle config only if all rules are supported

fb5cc81

return arsenal error of same type when available

0dd11c2

Metadata (the component) does return Arsenal errors but not as an instance of the Arsenal errors class. We should keep the same error type instead of returning an internal error. Issue: ARSN-490

Fix crash on buckets created with 7.70 branch

b08e642

Issue: ARSN-490

Fix validation of unsupported rules

1bfd26c

The validation is more strict, to explicitely reject non-supported rules. Issue: ARSN-490

Fix compute ContentLength from location

b483aef

The length cannot be computed when some data locations do not have a size, in which case the function must return `undefined` instead of possibly reporting any value. Issue: ARSN-490

francoisferrand added a commit to scality/cloudserver that referenced this pull request May 2, 2025

[TODO] Bump arsenal 8.2.13

cd78717

esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638

williamlardier approved these changes May 2, 2025

View reviewed changes

francoisferrand added a commit to scality/cloudserver that referenced this pull request May 2, 2025

[TODO] Bump arsenal 8.2.13

b964a45

esp. needs [1] [1] scality/Arsenal#2373 Issue: CLDSRV-638

francoisferrand requested review from jonathan-gramain and benzekrimaha May 2, 2025 16:20

jonathan-gramain approved these changes May 6, 2025

View reviewed changes

benzekrimaha reviewed May 7, 2025

View reviewed changes

benzekrimaha approved these changes May 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for cloudserver unification #2373

Fixes for cloudserver unification #2373

francoisferrand commented May 2, 2025 •

edited

Loading

bert-e commented May 2, 2025

bert-e commented May 2, 2025

codecov bot commented May 2, 2025

williamlardier left a comment

williamlardier May 2, 2025

williamlardier May 2, 2025

williamlardier May 2, 2025

williamlardier May 2, 2025

jonathan-gramain May 6, 2025

benzekrimaha May 7, 2025 •

edited

Loading

francoisferrand May 7, 2025

	// Memoize the supported lifecycle rules to avoid recalculating them
	// Memorize the supported lifecycle rules to avoid recalculating them

Fixes for cloudserver unification #2373

Are you sure you want to change the base?

Fixes for cloudserver unification #2373

Conversation

francoisferrand commented May 2, 2025 • edited Loading

bert-e commented May 2, 2025

Hello francoisferrand,

bert-e commented May 2, 2025

Waiting for approval

codecov bot commented May 2, 2025

Codecov Report

williamlardier left a comment

Choose a reason for hiding this comment

williamlardier May 2, 2025

Choose a reason for hiding this comment

williamlardier May 2, 2025

Choose a reason for hiding this comment

williamlardier May 2, 2025

Choose a reason for hiding this comment

williamlardier May 2, 2025

Choose a reason for hiding this comment

jonathan-gramain May 6, 2025

Choose a reason for hiding this comment

benzekrimaha May 7, 2025 • edited Loading

Choose a reason for hiding this comment

francoisferrand May 7, 2025

Choose a reason for hiding this comment

francoisferrand commented May 2, 2025 •

edited

Loading

benzekrimaha May 7, 2025 •

edited

Loading