Improvement/arsn 492

[benzekrimaha]

Issue: ARSN-492

[bert-e]

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-492 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.2.14

Please check the Fix Version/s of ARSN-492, or the target
branch of this pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (e14f533) to head (22a5462).

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2371      +/-   ##
===================================================
+ Coverage            69.91%   69.93%   +0.01%     
===================================================
  Files                  218      218              
  Lines                17440    17441       +1     
  Branches              3592     3593       +1     
===================================================
+ Hits                 12194    12198       +4     
+ Misses                5242     5239       -3     
  Partials                 4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[francoisferrand]

not sure we want to release just yet, we got a few more that also need to reach 9.0 very soon.

[benzekrimaha]

we will actually need to bump, for the s3utils PR

[francoisferrand]

yes we need to bump, but not on every PR. We currently have 3 PRs open in arsenal, all of which need to be bump'ed : so better to merge as many PRs as possible, and release/bump just once, after the last one of the batch.

[francoisferrand]

that is very weird:

• newBucketMD is the "serializable" variant of bucketMD: if typing is needed, it should be done in BucketInfo.makeSerializable
• adding the type in here will only affect this specific function, as payload is only used here
• Passing bucketMD.capabilities to createBucket() is not just for testing: today, maybe we do not do it "in prod" and only do it in tests, but since it is part of bucketInfo it should be supported, like all other fields... → if a fix is needed, it is not just for tests...