ARSN-439: Vaut/authenticateV2(4)Request error handling

[dvasilas]

Vaultclient's verifySignatureV2(4) returns an error that contains a code and a description field.
This error is propagated to the callers of authenticateV2(4)Request.

However, callers expect an ArsenalError.
This change fixes this specifically for the case of InvalidAccessKeyId (when a non-existing access key is given).

Issue: ARSN-439

[bert-e]

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Branches have diverged

This pull request's source branch bugfix/ARSN-439/authenticateV4Request-error-handling has diverged from
development/8.1 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

• Merge origin/development/8.1 into bugfix/ARSN-439/authenticateV4Request-error-handling
• Rebase bugfix/ARSN-439/authenticateV4Request-error-handling onto origin/development/8.1

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-439 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 7.70.36

• 8.1.139

• 8.2.0

Please check the Fix Version/s of ARSN-439, or the target
branch of this pull request.

[dvasilas]

ping

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[williamlardier]

Can we also try this change in cloudserver (I guess cloudserver CI should be enough, but because we don't really use vault there, maybe Integration/Zenko are needed) - just to be on the safe side, so we do not have any issue when the function returns an arsenal error

[dvasilas]

That's a good point. Not sure if we test this code path, I will check.

[nicolas2bert]

I feel like the issue we are facing is that we are sometimes managing Arsenal errors and other times 'request' errors, depending on the type of error and the backend being used. Should we consider translating 'request' errors into Arsenal errors so that we only need to manage one type of error?

[williamlardier]

Yes. Adding another note: we recently moved out of the arsenal errors in vaultclient, because we were importing the repo only to use these Arsenal errors (based on some metaprogramming logic, with perf impact). Maybe this is a more global thing to discuss here...