Skip to content

ARSN-21 Upgrade Node to 16 #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 20, 2022

Conversation

dimitri-bourreau
Copy link
Contributor

This PR aims to upgrade Node from 10 to 16.

Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
@bert-e
Copy link
Contributor

bert-e commented Dec 7, 2021

Hello dimitri-bourreau,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

Copy link
Contributor

@miniscruff miniscruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update the "engine" value in package.json as well

dimitri-bourreau and others added 7 commits December 9, 2021 00:38
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
Signed-off-by: Dimitri Bourreau <contact@dimitribourreau.me>
@bert-e
Copy link
Contributor

bert-e commented Jan 11, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-21 contains:

  • 7.10.6

  • 7.4.14

  • 8.1.18

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.6

  • 7.4.15

  • 8.1.19

Please check the Fix Version/s of ARSN-21, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Jan 12, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

@dimitri-bourreau
Copy link
Contributor Author

@bert-e help

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2022

Help page

The following options and commands are available at this time.

Options

name description privileged authored
➡️ bypass_incompatible_branch Bypass the check on the source branch prefix
➡️ bypass_jira_check Bypass the Jira issue check
➡️ bypass_peer_approval Bypass the pull request peers' approval
➡️ wait Instruct Bert-E not to run until further notice.
➡️ bypass_commit_size Bypass the check on the size of the changeset TBA
➡️ create_pull_requests Allow the creation of integration pull requests.
➡️ unanimity Change review acceptance criteria from one reviewer at least to all reviewers
➡️ bypass_build_status Bypass the build and test status
➡️ bypass_leader_approval Bypass the pull request leaders' approval
➡️ bypass_author_approval Bypass the pull request author's approval
➡️ approve Instruct Bert-E that the author has approved the pull request. ✍️
➡️ after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
➡️ no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead

Commands

name description privileged
➡️ clear Remove all comments from Bert-E from the history TBA
➡️ status Print Bert-E's current status in the pull request TBA
➡️ force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
➡️ reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.
➡️ retry Re-start a fresh build TBA
➡️ help Print Bert-E's manual in the pull request.
➡️ build Re-start a fresh build TBA

@dimitri-bourreau
Copy link
Contributor Author

@bert-e approve

@scality scality deleted a comment from bert-e Jan 19, 2022
@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

The following options are set: approve

@scality scality deleted a comment from bert-e Jan 19, 2022
@scality scality deleted a comment from bert-e Jan 19, 2022
@scality scality deleted a comment from bert-e Jan 19, 2022
@scality scality deleted a comment from bert-e Jan 19, 2022
@scality scality deleted a comment from bert-e Jan 19, 2022
@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.4

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • stabilization/7.4.10

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.4

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • stabilization/7.4.10

Please check the status of the associated issue ARSN-21.

Goodbye dimitri-bourreau.

@bert-e bert-e merged commit a1e14fc into development/7.4 Jan 20, 2022
@bert-e bert-e deleted the improvement/ARSN-21-Upgrade-Node-to-16 branch January 20, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants