Skip to content

fix: tag input and text area size #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
+25 −1
Merged

fix: tag input and text area size #5798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-chefs-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

`TagInput` and `TextArea`: fix size
3 changes: 3 additions & 0 deletions packages/ui/src/components/TagInput/styles.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,19 @@ export const tagInputContainer = recipe({
padding: `calc(${theme.space[TAGINPUT_SIZE_PADDING.large]} - 1px) ${
theme.space['2']
}`,
height: theme.sizing[600],
},
small: {
padding: `calc(${theme.space[TAGINPUT_SIZE_PADDING.small]} - 1px) ${
theme.space['1']
}`,
height: theme.sizing[400],
},
medium: {
padding: `calc(${theme.space[TAGINPUT_SIZE_PADDING.medium]} - 1px) ${
theme.space['2']
}`,
height: theme.sizing[500],
},
},
},
Expand Down
12 changes: 12 additions & 0 deletions packages/ui/src/components/TextArea/__stories__/Examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { AlertCircleOutlineIcon } from '@ultraviolet/icons'
import { useState } from 'react'
import { Badge } from '../../Badge'
import { Stack } from '../../Stack'
import { Text } from '../../Text'
import { TextInput } from '../../TextInput'
import { Tooltip } from '../../Tooltip'
import { TextArea } from '..'

Expand All @@ -13,6 +15,16 @@ export const Examples: StoryFn<typeof TextArea> = () => {

return (
<Stack gap={2}>
<Text as="div" variant="body">
Should be the same height as a TextInput when{' '}
<Text as="span" variant="code">
rows={1}
</Text>
</Text>
<Stack direction="row">
<TextArea label="textArea" onChange={setValue} rows={1} />
<TextInput label="textInput" />
</Stack>
<TextArea
label="Label"
maxLength={200}
Expand Down
5 changes: 4 additions & 1 deletion packages/ui/src/components/TextArea/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ export const TextArea = forwardRef<HTMLTextAreaElement, TextAreaProps>(
aria-invalid={!!error}
aria-label={ariaLabel}
autoFocus={autoFocus}
className={textAreaStyle({ error: !!error, success: !!success })}
className={textAreaStyle({
error: !!error,
success: !!success,
})}
data-testid={dataTestId}
disabled={disabled}
id={id ?? localId}
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/components/TextArea/styles.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const textAreaClearableContainer = style({
export const textArea = recipe({
base: {
width: '100%',
minHeight: theme.sizing[600],
resize: 'vertical',
background: theme.colors.neutral.background,
border: `1px solid ${theme.colors.neutral.border}`,
Expand Down
Loading