Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-windows-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": minor
---

`SelectableCard`: add "stopPropagation" in the children for keyboard events
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Row } from '../../Row'
import { SelectInput } from '../../SelectInput'
import { Stack } from '../../Stack'
import { Text } from '../../Text'
import { TextArea } from '../../TextArea'
import { SelectableCard } from '..'
import fr from './assets/fr.svg'
import nl from './assets/nl.svg'
Expand All @@ -24,6 +25,9 @@ export const Examples: StoryFn = args => {
'label-27': false,
'label-28': false,
})
const [value5, onChange5] = useState({
'label-29': false,
})

return (
<Stack flex={1} gap={8}>
Expand Down Expand Up @@ -312,6 +316,21 @@ export const Examples: StoryFn = args => {
value="label-28"
/>
</Row>
<SelectableCard
{...args}
checked={value5['label-29']}
label="With an input in the children"
name="label-29" // fixed: match the state key
onChange={
event =>
onChange5({ ...value5, 'label-29': event.currentTarget.checked }) // fixed: spread value5
}
showTick
type="checkbox"
value="label-29" // fixed: match the state key
>
<TextArea label="" onChange={() => {}} />
</SelectableCard>
</Stack>
)
}
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/components/SelectableCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ export const SelectableCard = forwardRef(
type === 'checkbox' && isComplexChildren
}
data-has-label={!!label && showTick}
onKeyDown={event => event.stopPropagation()}
ref={childrenRef}
width="100%"
>
Expand Down
Loading