Skip to content

fix(Checkbox): classname #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix(Checkbox): classname #5660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tangy-news-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/ui": patch
---

`Checkbox`: fix classname
14 changes: 7 additions & 7 deletions packages/form/src/components/CheckboxField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`checkboxField > should render correctly 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -67,7 +67,7 @@ exports[`checkboxField > should render correctly checked without value 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -124,7 +124,7 @@ exports[`checkboxField > should render correctly disabled 1`] = `
>
<div
aria-disabled="true"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -181,7 +181,7 @@ exports[`checkboxField > should render correctly not checked without value 1`] =
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -237,7 +237,7 @@ exports[`checkboxField > should render correctly with aria-label 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -294,7 +294,7 @@ exports[`checkboxField > should render correctly with errors 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="true"
>
Expand Down Expand Up @@ -375,7 +375,7 @@ exports[`checkboxField > should trigger events correctly 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down
8 changes: 4 additions & 4 deletions packages/form/src/components/CheckboxGroupField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`checkboxField > should render correctly checked 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_19cjf6j1"
class="uv_19cjf6j1 uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -91,7 +91,7 @@ exports[`checkboxField > should render correctly checked 1`] = `
</div>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_19cjf6j1"
class="uv_19cjf6j1 uv_9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -198,7 +198,7 @@ exports[`checkboxField > should trigger events correctly with required prop 1`]
>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_19cjf6j1"
class="uv_19cjf6j1 uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -257,7 +257,7 @@ exports[`checkboxField > should trigger events correctly with required prop 1`]
</div>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_19cjf6j1"
class="uv_19cjf6j1 uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down
6 changes: 3 additions & 3 deletions .../form/src/components/SelectableCardGroupField/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ exports[`selectableCardField > should render correctly checked as a checkbox 1`]
>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_475tndc"
class="uv_475tndc uv_9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -435,7 +435,7 @@ exports[`selectableCardField > should trigger events correctly 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_475tndc"
class="uv_475tndc uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -506,7 +506,7 @@ exports[`selectableCardField > should trigger events correctly 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 uv_475tndc"
class="uv_475tndc uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down
16 changes: 8 additions & 8 deletions packages/plus/src/components/OfferList/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7524,7 +7524,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -7597,7 +7597,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -7670,7 +7670,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -7743,7 +7743,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -7816,7 +7816,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -7890,7 +7890,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -7963,7 +7963,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -8036,7 +8036,7 @@ exports[`offerList > should work with selectable - checkbox 1`] = `
>
<div
aria-disabled="false"
class="uv_9pjq8o6 undefined"
class="uv_9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down
28 changes: 14 additions & 14 deletions packages/ui/src/components/Checkbox/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`checkbox > renders correctly 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -74,7 +74,7 @@ exports[`checkbox > renders correctly checked 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -141,7 +141,7 @@ exports[`checkbox > renders correctly checked and disabled 1`] = `
>
<div
aria-disabled="true"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -209,7 +209,7 @@ exports[`checkbox > renders correctly checked with helper 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="true"
data-error="false"
>
Expand Down Expand Up @@ -281,7 +281,7 @@ exports[`checkbox > renders correctly disabled 1`] = `
>
<div
aria-disabled="true"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -348,7 +348,7 @@ exports[`checkbox > renders correctly indeterminate 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="indeterminate"
data-error="false"
>
Expand Down Expand Up @@ -412,7 +412,7 @@ exports[`checkbox > renders correctly indeterminate and disabled 1`] = `
>
<div
aria-disabled="true"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="indeterminate"
data-error="false"
>
Expand Down Expand Up @@ -477,7 +477,7 @@ exports[`checkbox > renders correctly invisible 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
data-visibility="true"
Expand Down Expand Up @@ -544,7 +544,7 @@ exports[`checkbox > renders correctly no child 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -595,7 +595,7 @@ exports[`checkbox > renders correctly required 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -667,7 +667,7 @@ exports[`checkbox > renders correctly with a value 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down Expand Up @@ -734,7 +734,7 @@ exports[`checkbox > renders correctly with an error 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="true"
>
Expand Down Expand Up @@ -806,7 +806,7 @@ exports[`checkbox > renders correctly with indeterminate state 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="indeterminate"
data-error="false"
>
Expand Down Expand Up @@ -876,7 +876,7 @@ exports[`checkbox > renders correctly with tooltip 1`] = `
>
<div
aria-disabled="false"
class="styles__9pjq8o6 undefined"
class="styles__9pjq8o6"
data-checked="false"
data-error="false"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/Checkbox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const Checkbox = forwardRef<HTMLInputElement, CheckboxProps>(
<Tooltip text={tooltip}>
<div
aria-disabled={disabled}
className={`${checkboxContainer ? `${checkboxContainer} ` : ''}${className}`}
className={`${className ? `${className} ` : ''}${checkboxContainer}`}
data-checked={checked}
data-error={!!error}
data-testid={dataTestId}
Expand Down
Loading
Loading