fix(TextInputV2): allow clearable for uncontrolled #5224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c742a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
johnrazeur
force-pushed
the
fix_textinputv2_clearable_uncontrolled
branch
from
fb50da2 to
b3b47c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 236 236
Lines 8361 8365 +4
Branches 3752 3802 +50
=======================================
+ Hits 7418 7422 +4
Misses 943 943
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
johnrazeur
force-pushed
the
fix_textinputv2_clearable_uncontrolled
branch
from
b3b47c0 to
1c742a8
Compare
matthprost
approved these changes
Jun 10, 2025
lisalupi
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Allow clearable for uncontrolled TextIputv2