Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpcgw): retry update instead of resolving dns on ip_reverse_dns #1927

Merged
merged 2 commits into from
May 10, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented May 9, 2023

No description provided.

@yfodil yfodil added bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels May 9, 2023
@yfodil yfodil self-assigned this May 9, 2023
@yfodil yfodil marked this pull request as ready for review May 10, 2023 07:49
@codecov-commenter
Copy link

Codecov Report

Merging #1927 (f1725b3) into master (68b3bfe) will increase coverage by 0.02%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master    #1927      +/-   ##
==========================================
+ Coverage   74.44%   74.46%   +0.02%     
==========================================
  Files         173      173              
  Lines       26759    26753       -6     
==========================================
+ Hits        19921    19922       +1     
+ Misses       5153     5146       -7     
  Partials     1685     1685              
Impacted Files Coverage Δ
scaleway/helpers_domain.go 83.61% <ø> (+5.53%) ⬆️
scaleway/helpers_vpcgw.go 70.58% <36.36%> (-12.52%) ⬇️
scaleway/resource_vpc_public_gateway_ip_reverse.go 60.68% <50.00%> (+2.96%) ⬆️
scaleway/resource_vpc_public_gateway_ip.go 67.80% <75.00%> (-1.04%) ⬇️

@remyleone remyleone added this pull request to the merge queue May 10, 2023
Merged via the queue into scaleway:master with commit 368c25e May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants