Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis): enable ipam on private network #1925

Merged
merged 1 commit into from
May 10, 2023
Merged

feat(redis): enable ipam on private network #1925

merged 1 commit into from
May 10, 2023

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented May 9, 2023

No description provided.

@Monitob Monitob added the redis Managed Redis issues, bugs and feature requests label May 9, 2023
@Monitob Monitob self-assigned this May 9, 2023
@Monitob Monitob linked an issue May 9, 2023 that may be closed by this pull request
Add ipamConfig for Redis #1864
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #1925 (afcd7fc) into master (68b3bfe) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   74.44%   74.43%   -0.01%     
==========================================
  Files         173      173              
  Lines       26759    26763       +4     
==========================================
+ Hits        19921    19922       +1     
- Misses       5153     5156       +3     
  Partials     1685     1685
Impacted Files Coverage Δ
scaleway/helpers_redis.go 86.25% <50.00%> (-1.93%) ⬇️
scaleway/resource_redis_cluster.go 76.37% <100.00%> (ø)

@remyleone remyleone added this pull request to the merge queue May 10, 2023
Merged via the queue into scaleway:master with commit 931bfcd May 10, 2023
@Monitob Monitob deleted the feat-redis-support-ipam branch May 11, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
redis Managed Redis issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ipamConfig for Redis
3 participants
@Monitob @codecov-commenter @remyleone