Skip to content

Commit

Permalink
fix: set different record names on instance & vpcgw ip reverse tests (#…
Browse files Browse the repository at this point in the history
…1928)

* fix: set different dns_zones and record names on instance & vpcgw ip reverse tests

* update cassettes

* update tests & cassettes
  • Loading branch information
yfodil authored May 12, 2023
1 parent 60a69be commit cc82175
Show file tree
Hide file tree
Showing 4 changed files with 347 additions and 314 deletions.
8 changes: 4 additions & 4 deletions scaleway/resource_instance_ip_reverse_dns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
func TestAccScalewayInstanceIPReverseDns_Basic(t *testing.T) {
tt := NewTestTools(t)
defer tt.Cleanup()
testDNSZone := fmt.Sprintf("%s.%s", testDomainZone, testDomain)
testDNSZone := fmt.Sprintf("tf-reverse-instance.%s", testDomain)
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand All @@ -22,21 +22,21 @@ func TestAccScalewayInstanceIPReverseDns_Basic(t *testing.T) {
resource "scaleway_domain_record" "tf_A" {
dns_zone = %[1]q
name = "tf"
name = "tf-reverse-instance"
type = "A"
data = "${scaleway_instance_ip.main.address}"
ttl = 3600
priority = 1
}
`, testDomain, testDNSZone),
`, testDomain),
},
{
Config: fmt.Sprintf(`
resource "scaleway_instance_ip" "main" {}
resource "scaleway_domain_record" "tf_A" {
dns_zone = %[1]q
name = "tf"
name = "tf-reverse-instance"
type = "A"
data = "${scaleway_instance_ip.main.address}"
ttl = 3600
Expand Down
4 changes: 2 additions & 2 deletions scaleway/resource_vpc_public_gateway_ip_reverse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
func TestAccScalewayVPCPublicGatewayIPReverseDns_Basic(t *testing.T) {
tt := NewTestTools(t)
defer tt.Cleanup()
testDNSZone := fmt.Sprintf("%s.%s", testDomainZone, testDomain)
testDNSZone := fmt.Sprintf("tf-reverse-vpcgw.%s", testDomain)
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
ProviderFactories: tt.ProviderFactories,
Expand All @@ -24,7 +24,7 @@ func TestAccScalewayVPCPublicGatewayIPReverseDns_Basic(t *testing.T) {
resource "scaleway_domain_record" "tf_A" {
dns_zone = %[1]q
name = "tf"
name = "tf-reverse-vpcgw"
type = "A"
data = "${scaleway_vpc_public_gateway_ip.main.address}"
ttl = 3600
Expand Down
Loading

0 comments on commit cc82175

Please sign in to comment.