Skip to content

Fix error type serverless invoke #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Fix error type serverless invoke #148

merged 2 commits into from
Mar 8, 2023

Conversation

thomas-tacquet
Copy link
Contributor

Mentionned in #147

The error returned by function calls on serverless invoke command was not readable because of the wrong type.

After toString conversion :

 serverless invoke --function testfunc
[...]
AxiosError: Request failed with status code 403%

@thomas-tacquet thomas-tacquet requested a review from Shillaker March 6, 2023 16:31
@Cubox
Copy link

Cubox commented Mar 7, 2023

Minor thing, but the % at the end of the message is due to zsh signaling there was no newline after that text.
Maybe add a \n after the text?

@thomas-tacquet
Copy link
Contributor Author

Minor thing, but the % at the end of the message is due to zsh signaling there was no newline after that text. Maybe add a \n after the text?

Oh sure, fixed and tested 👌

serverless invoke --function testfunc
[...]
AxiosError: Request failed with status code 403

@thomas-tacquet thomas-tacquet merged commit 454fa75 into master Mar 8, 2023
@thomas-tacquet thomas-tacquet deleted the fix-error-type branch March 8, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants