Skip to content

Conversation

@DorianMaliszewski
Copy link
Member

The feature

  • Allow user to scope the e2e sweepers to the default project id only and not every project in the organization

Implementation

  • Use a flag projectScoped that change the function behavior when set to true.
  • Functions will only target the SCW_DEFAULT_PROJECT_ID passed instead of all projects in the organization
  • For some sweepers we need to make a first call that list the resources to target in the project (like crons in functions)

@DorianMaliszewski DorianMaliszewski requested review from a team and remyleone as code owners October 6, 2025 13:56
@github-actions github-actions bot added redis Managed Redis issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests instance Instance issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests account Account issues, bugs and feature requests baremetal vpcgw labels Oct 6, 2025
@DorianMaliszewski DorianMaliszewski force-pushed the tests/project-scoped-sweepers branch 3 times, most recently from cc44449 to e59a867 Compare October 7, 2025 15:15
@DorianMaliszewski DorianMaliszewski force-pushed the tests/project-scoped-sweepers branch from e59a867 to d5ab191 Compare November 25, 2025 16:29
@DorianMaliszewski DorianMaliszewski force-pushed the tests/project-scoped-sweepers branch from d5ab191 to 817f222 Compare November 25, 2025 16:47
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 688 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.71%. Comparing base (11c2e45) to head (817f222).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/cockpit/v1/sweepers/sweepers.go 0.00% 88 Missing ⚠️
api/mnq/v1beta1/sweepers/sweepers.go 0.00% 87 Missing ⚠️
api/function/v1beta1/sweepers/sweepers.go 0.00% 73 Missing ⚠️
api/instance/v1/sweepers/sweepers.go 0.00% 72 Missing ⚠️
api/vpcgw/v1/sweepers/sweepers.go 0.00% 38 Missing ⚠️
api/mongodb/v1/sweepers/sweepers.go 0.00% 37 Missing ⚠️
api/container/v1beta1/sweepers/sweepers.go 0.00% 31 Missing ⚠️
api/vpc/v2/sweepers/sweepers.go 0.00% 28 Missing ⚠️
api/block/v1alpha1/sweepers/sweepers.go 0.00% 21 Missing ⚠️
api/mongodb/v1alpha1/sweepers/sweepers.go 0.00% 21 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2757      +/-   ##
=========================================
- Coverage    3.74%   3.71%   -0.04%     
=========================================
  Files         153     153              
  Lines       48658   49095     +437     
=========================================
  Hits         1823    1823              
- Misses      46556   46993     +437     
  Partials      279     279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

account Account issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests baremetal container Container issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants