Skip to content

Conversation

@Lawndlwd
Copy link
Member

Issue on ParamsRef
Issue: The method function stored in the Data Loader was capturing stale params.

When baseParams changed (region switched), paramsRef wasn't updated until an effect ran after render, but the request was already created with the old params.

Using memo will reflect the changes immediately, and I didn't see we need a ref here

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: 09fd96e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-dataloader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.85%. Comparing base (144bac9) to head (09fd96e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2812      +/-   ##
==========================================
- Coverage   68.92%   68.85%   -0.08%     
==========================================
  Files          44       44              
  Lines        1297     1294       -3     
  Branches      181      181              
==========================================
- Hits          894      891       -3     
  Misses        380      380              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lawndlwd Lawndlwd enabled auto-merge (squash) October 16, 2025 12:45
@Lawndlwd Lawndlwd merged commit 72ac1e2 into main Oct 16, 2025
5 checks passed
@Lawndlwd Lawndlwd deleted the fix-infinty-loader branch October 16, 2025 12:47
@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants