Update tags docs #36
Merged
Update tags docs #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtherin
approved these changes
Oct 18, 2020
Contributor
Author
|
By the way, is this feature documented somewhere? Is there a user documentation about Kapsule? |
Contributor
|
Nop it's only here 😅 we miss a central place for documentation about the product :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the tags on a pool to add a taint to all the nodes of that pool, as described in
tags.md.I added the tag
taint=foo:bar:NoExecuteto the pool. After waiting for a couple of minutes, the node in that pool received the taintk8s.scaleway.com/foobar:NoExecuteinstead ofk8s.scaleway.com/foo=bar:NoExecute.After reading
sync_test.goI noticed that the expected syntax for the tags of pools istaint=foo=bar:Effect.I tried it and it worked: my node has now the taint
k8s.scaleway.com/foo=bar:NoExecute.I fixed the docs according to this.
Also I fixed a typo...