Skip to content

feat(instance): redirect to scw login when no credentials are provided #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Mia-Cross
Copy link
Contributor

Closes #4080

@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests high-impact priority:high New features labels Mar 26, 2025
@Mia-Cross Mia-Cross self-assigned this Mar 26, 2025
@github-actions github-actions bot removed the instance Instance issues, bugs and feature requests label Mar 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 55.22%. Comparing base (5bf53e0) to head (1eba328).
Report is 559 commits behind head on master.

Files with missing lines Patch % Lines
internal/platform/terminal/terminal_client.go 0.00% 13 Missing ⚠️
core/client.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (1eba328). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (1eba328)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4617       +/-   ##
===========================================
- Coverage   75.45%   55.22%   -20.23%     
===========================================
  Files         202      304      +102     
  Lines       44323    69757    +25434     
===========================================
+ Hits        33444    38524     +5080     
- Misses       9653    29836    +20183     
- Partials     1226     1397      +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the redirect_to_scw_login branch from f7d2c5e to 45429f7 Compare March 26, 2025 14:17
@Mia-Cross Mia-Cross force-pushed the redirect_to_scw_login branch from 45429f7 to 1eba328 Compare March 26, 2025 14:23
@Mia-Cross Mia-Cross marked this pull request as ready for review March 26, 2025 14:24
@Mia-Cross Mia-Cross requested a review from remyleone as a code owner March 26, 2025 14:24
@remyleone remyleone added this pull request to the merge queue Mar 26, 2025
Merged via the queue into scaleway:master with commit aa8fdae Mar 26, 2025
14 checks passed
@Mia-Cross Mia-Cross deleted the redirect_to_scw_login branch March 26, 2025 15:39
Laure-di pushed a commit to remyleone/scaleway-cli that referenced this pull request Apr 4, 2025
Laure-di pushed a commit to scaleway-bot/scaleway-cli that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect towards scw login if no credentials are created
3 participants