-
Notifications
You must be signed in to change notification settings - Fork 152
fix(rdb): acl: add description field #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
remyleone
merged 10 commits into
scaleway:master
from
Mia-Cross:rdb_acl_fix_breaking_change
Feb 29, 2024
Merged
fix(rdb): acl: add description field #3683
remyleone
merged 10 commits into
scaleway:master
from
Mia-Cross:rdb_acl_fix_breaking_change
Feb 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7c53a9
to
a65b104
Compare
remyleone
reviewed
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3683 +/- ##
=======================================
Coverage 75.81% 75.82%
=======================================
Files 190 190
Lines 42666 42676 +10
=======================================
+ Hits 32347 32357 +10
Misses 9129 9129
Partials 1190 1190 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
priority:highest
Bugs filled by customers, security issues
rdb
Managed MySQL and PostgreSQL issues, bugs and feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
description
field back in therdb acl add
command, as #3577 only set a default value.For now, indexes are not supported (we need #3595 first) so in the meantime, if a description is provided for this type of command:
the description will be added to all the rules of the command.
If you wish to add different description, you should split your command:
Closes #3671