Skip to content

fix(rdb): acl: add description field #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Feb 26, 2024

This PR brings the description field back in the rdb acl add command, as #3577 only set a default value.
For now, indexes are not supported (we need #3595 first) so in the meantime, if a description is provided for this type of command:

scw rdb acl add 1.2.3.4 1.1.1.1 description="useful description"

the description will be added to all the rules of the command.

If you wish to add different description, you should split your command:

scw rdb acl add 1.2.3.4 description="useful description"
scw rdb acl add 1.1.1.1 description="another description"

Closes #3671

@Mia-Cross Mia-Cross added bug rdb Managed MySQL and PostgreSQL issues, bugs and feature requests priority:highest Bugs filled by customers, security issues labels Feb 26, 2024
@Mia-Cross Mia-Cross self-assigned this Feb 26, 2024
@Mia-Cross Mia-Cross marked this pull request as draft February 26, 2024 15:48
@Mia-Cross Mia-Cross force-pushed the rdb_acl_fix_breaking_change branch from c7c53a9 to a65b104 Compare February 26, 2024 17:09
@Mia-Cross Mia-Cross marked this pull request as ready for review February 26, 2024 17:21
@Mia-Cross Mia-Cross marked this pull request as draft February 27, 2024 09:39
@Mia-Cross Mia-Cross marked this pull request as ready for review February 27, 2024 15:57
@Mia-Cross Mia-Cross changed the title fix(rdb): acl: revert breaking change fix(rdb): acl: add description field Feb 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.82%. Comparing base (f887258) to head (e25815d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3683   +/-   ##
=======================================
  Coverage   75.81%   75.82%           
=======================================
  Files         190      190           
  Lines       42666    42676   +10     
=======================================
+ Hits        32347    32357   +10     
  Misses       9129     9129           
  Partials     1190     1190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Feb 29, 2024
Merged via the queue into scaleway:master with commit 47965e4 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority:highest Bugs filled by customers, security issues rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDB: ACL can't have custom description since 2.27.0
3 participants