Upgrade vault java driver and add kubernetes support #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segabriel
requested review from
aharonha,
artem-v,
skolomiiets and
dmytro-lazebnyi
and removed request for
skolomiiets
aharonha
requested changes
Oct 2, 2019
config-vault/src/main/java/io/scalecube/config/vault/KubernetesVaultTokenSupplier.java
Show resolved
Hide resolved
config-vault/src/test/java/io/scalecube/config/vault/VaultConfigSourceTest.java
Show resolved
Hide resolved
config-vault/src/test/java/io/scalecube/config/vault/VaultConfigSourceTest.java
Outdated
Show resolved
Hide resolved
config-vault/src/test/java/io/scalecube/config/vault/VaultConfigSourceTest.java
Outdated
Show resolved
Hide resolved
config-vault/src/test/java/io/scalecube/config/vault/VaultInstance.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Aharon Hacmon <aharonha@users.noreply.github.com>
…igSourceTest.java Co-Authored-By: Aharon Hacmon <aharonha@users.noreply.github.com>
segabriel
force-pushed
the
upgrade-vault-java-driver
branch
from
a24f0d7 to
288b27a
Compare
This was referenced Oct 25, 2019
artem-v
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Closes #129
Also, see link https://github.com/jenkinsci/hashicorp-vault-plugin/blob/f60221d0748ae438aec2e0331eee0d8f450d5eb0/src/main/java/com/datapipe/jenkins/vault/credentials/VaultKubernetesCredential.java