This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Improved logging, split by benchmark tests #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-v
suggested changes
Jul 20, 2018
| @@ -51,6 +52,9 @@ | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(BenchmarksState.class); | |||
|
|
|||
| private static final String MDC_BENCHMARK_DIR = "benchmarkDir"; | |||
| private static final String MDC_BENCHMARK_NAME = "benchmarkName"; | |||
There was a problem hiding this comment.
We dont need MDC_BENCHMARK_NAME since MDC_BENCHMARK_DIR is already uniquily defines path to log directory
| <Route> | ||
| <RollingFile name="Rolling-${ctx:benchmarkDir}-${ctx:benchmarkName}" | ||
| fileName="${ctx:benchmarkDir}/${ctx:benchmarkName}.log" | ||
| filePattern="${ctx:benchmarkDir}/${ctx:benchmarkName}-%d{yyyy-MM-dd-HH}.log"> |
There was a problem hiding this comment.
${ctx:benchmarkName} is redudant, since benchmarkDir is alredy uniquily defines name of the test. Instead of ${ctx:benchmarkName} just put benchamarks .
| @@ -0,0 +1,50 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Plz move this file out of api to examples module and call it log4j2-example.xml. Also we have to put some documentation about this logging approach and share it on wiki page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.