-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
|
||
latch.await(settings.executionTaskDuration().toMillis(), TimeUnit.MILLISECONDS); | ||
} catch (InterruptedException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better just propagate with Exceptions.propagate(e)
. Can u put right after this comment an improvement whihch this parallel thing is giving to us. I heard u told it's like 2x perf boost. Ok, can u put the stats right here. Like, here it was, here it became.
@@ -279,7 +293,7 @@ public final void runForAsync(Function<SELF, Function<Long, Publisher<?>>> func) | |||
|
|||
BiFunction<Long, T, Publisher<?>> unitOfWork = func.apply(self); | |||
|
|||
Flux.interval(settings.rampUpInterval()) | |||
Flux.interval(Duration.ZERO, settings.rampUpInterval()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
@@ -239,12 +247,18 @@ public final void runForAsync(Function<SELF, Function<Long, Publisher<?>>> func) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you have said runForAsync doesn't work well with this parallel() runOn()
trick . Plz revert .
I run
And after:
|
Have you noticed one thing: tps rate became larger 2x times, but latency is worsen. That's strange. I run sync exmple runner locally and indeed tps went top 2x times , but latency remained the same, just saying you stats are confusing. But we will merge this PR because it's really improves sync tests. Good job, thanks. PS on my laptop
After:
|
No description provided.