Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Updated readme #47

Merged
merged 6 commits into from
Jul 18, 2018
Merged

Updated readme #47

merged 6 commits into from
Jul 18, 2018

Conversation

segabriel
Copy link
Member

No description provided.

README.md Outdated

## Download

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add xml righ after the third `, this will give color scheme for xml

README.md Outdated

First, you need to create the settings which will be used while test is running. You can use the builder for it:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add java just right after third ` , this will give java colors

README.md Outdated

```
public static void main(String[] args) {
BenchmarksSettings settings = ...;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to put real ramp up settings right here, and in description below, you could refer to them so the reader would understand what this ramp-up thing is all about. So far text is too verbose and needs more factual content.

}
```

As you see, you could want to override some default settings with the command line, just include them during startup of the test. Or just use the hardcoded style when you write a test scenario.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just include them

Elaborate more maybe about few of them. So far it is not clear what settings you are referring to.

@segabriel segabriel added the ready for review ready for review label Jul 18, 2018
Copy link
Contributor

@artem-v artem-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@artem-v artem-v merged commit 334fffa into develop Jul 18, 2018
@artem-v artem-v deleted the feature/update-readme branch July 18, 2018 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants