Skip to content

add attachment url option flag #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2023
Merged

add attachment url option flag #77

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1202fc5
add attachment url option flag
jonathanfeng-scale Jun 13, 2023
4ccc37c
include test
jonathanfeng-scale Jun 13, 2023
cc4716f
formating
jonathanfeng-scale Jun 13, 2023
b3bcca0
more reformatting
jonathanfeng-scale Jun 13, 2023
ce25596
remove test case
jonathanfeng-scale Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove test case
  • Loading branch information
@jonathanfeng-scale
jonathanfeng-scale committed Jun 13, 2023
commit ce2559650ddf40e19536b1aea38624d1b731f19f
13 changes: 0 additions & 13 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,19 +408,6 @@ def test_get_tasks():
assert task.id in task_ids


def test_get_tasks_returns_attachment():
batch = create_a_batch()
tasks = []
for _ in range(1):
tasks.append(make_a_task(batch=batch.name))
for task in client.get_tasks(
project_name=TEST_PROJECT_NAME,
batch_name=batch.name,
include_attachment_url=True,
):
assert task.as_dict()["attachmentS3Downloads"]


def test_get_tasks_count():
tasks_count = client.tasks(project=TEST_PROJECT_NAME).total
get_tasks_count = client.get_tasks_count(project_name=TEST_PROJECT_NAME)
Expand Down