exclude_archived param added to batches retrieval #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lautarorangil
approved these changes
May 24, 2023
fatihkurtoglu
approved these changes
May 24, 2023
There was a problem hiding this comment.
Lgtm, left a nit comment.
Thanks for extending the batches retrieval parameters.
Two points I want to add:
exclude_archivedis not documented on our API docs, we can add it to the list of params on this page: https://docs.scale.com/reference/batch-list- In the same API ref doc, we also have
audited_afterandaudited_beforeparams too. We can also add those two options to the list of args we support forget_batchesmethod, it will be additional few lines only. Those attributes were also mentioned in issue client.get_batches() missing query parameters #60 too.
jonathanfeng-scale
approved these changes
May 30, 2023
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Co-authored-by: Fatih Kurtoglu <fatih.kurtoglu@scale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Added an
exclude_archivedadditional filter to remove archived batches on retrieval.