Skip to content

feat. Unset pydantic_data_converter if OpenAI Agents plugin being used #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

feat. Unset pydantic_data_converter if OpenAI Agents plugin being used #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/agentex/lib/core/clients/temporal/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from temporalio.client import Client, Plugin as ClientPlugin
from temporalio.runtime import Runtime, TelemetryConfig, OpenTelemetryConfig
from temporalio.contrib.pydantic import pydantic_data_converter
from temporalio.contrib.openai_agents import OpenAIAgentsPlugin

# class DateTimeJSONEncoder(AdvancedJSONEncoder):
# def default(self, o: Any) -> Any:
Expand Down Expand Up @@ -74,20 +75,24 @@ async def get_temporal_client(temporal_address: str, metrics_url: str | None = N
if plugins:
validate_client_plugins(plugins)

# Check if OpenAI plugin is present - it needs to configure its own data converter
has_openai_plugin = any(
isinstance(p, OpenAIAgentsPlugin) for p in (plugins or [])
)

# Only set data_converter if OpenAI plugin is not present
connect_kwargs = {
"target_host": temporal_address,
"plugins": plugins,
}

if not has_openai_plugin:
connect_kwargs["data_converter"] = pydantic_data_converter

if not metrics_url:
client = await Client.connect(
target_host=temporal_address,
# data_converter=custom_data_converter,
data_converter=pydantic_data_converter,
plugins=plugins,
)
client = await Client.connect(**connect_kwargs)
else:
runtime = Runtime(telemetry=TelemetryConfig(metrics=OpenTelemetryConfig(url=metrics_url)))
client = await Client.connect(
target_host=temporal_address,
# data_converter=custom_data_converter,
data_converter=pydantic_data_converter,
runtime=runtime,
plugins=plugins,
)
connect_kwargs["runtime"] = runtime
client = await Client.connect(**connect_kwargs)
return client