Add model run name for model.run #435
Merged
+19
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatli
approved these changes
Mar 27, 2024
tests/test_dataset.py
Outdated
| @@ -382,7 +382,6 @@ def test_annotate_async(dataset: Dataset): | |||
| "status": "Completed", | |||
| "message": { | |||
There was a problem hiding this comment.
This is a terrible testing pattern that we're still unwinding - we shouldn't be checking the message at all. We can test that in scaleapi unit tests if we want.
Can change the test to use assert_partial_equality and ideally just check the status message or the subset that indicates succes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model run nam has been made required in scale api, this PR adds the
model_run_nameparameter toModel.run.