[Validate] Scene-level scenario tests and custom metrics uploads#372
Merged
anthonykrivonos merged 10 commits intomasterfrom Nov 15, 2022
Merged
[Validate] Scene-level scenario tests and custom metrics uploads#372anthonykrivonos merged 10 commits intomasterfrom
anthonykrivonos merged 10 commits intomasterfrom
Conversation
vayunalapati
approved these changes
Nov 7, 2022
gatli
requested changes
Nov 8, 2022
Contributor
gatli
left a comment
gatli
left a comment
There was a problem hiding this comment.
We need to figure out how we want to expose that scenario tests can be of multiple levels.
I don't like the idea of adding
get_items
get_scenes
get_objects
get_tracks
where each one of these returns an empty list for different enums of levels. Let's just keep the get_items interface and switch there what types of items are returned based on the level of the test.
anthonykrivonos
commented
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.