Skip to content

fix scene export payload; bump circleci resource_class#342

Merged
drakejwong merged 4 commits intomasterfrom
drake-fix-scene-payload
Aug 10, 2022
Merged

fix scene export payload; bump circleci resource_class#342
drakejwong merged 4 commits intomasterfrom
drake-fix-scene-payload

Conversation

@drakejwong
Copy link
Contributor

@drakejwong drakejwong commented Aug 9, 2022 •
edited
Loading

  • Fix keys when parsing Scene.to_json payload back into Scene.from_json
  • Bump CircleCI resource_class from small -> medium...we'll have to investigate whether there was a regression later

anthonykrivonos
anthonykrivonos approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@anthonykrivonos anthonykrivonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙌

@drakejwong drakejwong changed the title fix scene export payload fix scene export payload; bump circleci resource_class Aug 9, 2022
@drakejwong drakejwong merged commit e90b2c7 into master Aug 10, 2022
@drakejwong drakejwong deleted the drake-fix-scene-payload branch August 10, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennifer-scale jennifer-scale Awaiting requested review from jennifer-scale

1 more reviewer

@anthonykrivonos anthonykrivonos anthonykrivonos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drakejwong @anthonykrivonos