Repository navigation
feat(task_step): prompt_agent sets the user-sim's persona (user_system_prompt) - #174
Open
kaihackney-scale wants to merge 1 commit into
Open
kaihackney-scale wants to merge 1 commit into
kaihackney-scale wants to merge 1 commit into
Conversation
…m_prompt) A user-sim installed with install_agent (e.g. co-located with the solver on one VM) has no way to get a system prompt: install_agent sets none, and prompt_agent sent the user only output_format and model, so it answered as a generic assistant. user_system_prompt is sent through the user-sim's agent-config extension like the solver's system_prompt, with seed placeholders applied. It fails loudly when there's no deployed user-sim or the user-sim's agent-config doesn't accept system_prompt. Serialized only when set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user-sim installed with
install_agent, for example co-located on the solver's VM, had no way to get a persona.install_agentsets no system prompt, andprompt_agentsent the user agent onlyoutput_formatandmodel. In a prod test with the solver and user on one VM, the uninstructed user just answered as a generic assistant ("I'm ready to help!").prompt_agentnow takesuser_system_prompt. It's sent through the user-sim's agent-config extension the same way the solver'ssystem_promptis, with seed placeholders applied. The step fails before any turn if there's no deployed user-sim, or if the user-sim's agent-config doesn't acceptsystem_prompt. A silently dropped persona would bring back the generic-assistant behaviour unnoticed. The field is keyword-only and serialized only when set, so existing tasks and positional callers are unchanged. The "Configured user-sim" log now lists the fields it set.Validation: new unit tests cover delivery with the seed applied, the unset case, and both refusals, and I checked that the delivery test fails without the change. The full unit suite passes (7494), except the two
test_mcp_cli_buildertests that fail the same way onmain. On prod (task-kai-colocate-user-system-prompt, run from this branch), the solver was deployed and the user-sim installed on one VM withuser_system_promptset. The user opened in persona ("Hi! I'm Dana Ortiz, a product manager… write me a two-line poem about coffee") and ended the conversation once it had the poem. The same setup without it got "I'm ready to help!".🤖 Generated with Claude Code


Confidence Score: 5/5
This PR appears safe to merge; no actionable issues were found.Summary
Adds
user_system_promptso a deployed user-sim can receive a persona before the conversation starts.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A["user_system_prompt set"] --> B{"Deployed user-sim selected?"} B -->|No| F["Fail before any turn"] B -->|Yes| C["Apply seed values"] C --> D{"Card accepts system_prompt?"} D -->|No| F D -->|Yes| E["Post user-sim configuration"] E --> G["Start conversation"]Reviews (1) · Last reviewed commit: "feat(task_step): prompt_agent sets the u..." · Reviewed by Greptile