Feature: MyAlgo Wallet Multisig #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megha-Dev-19
requested review from
vuvoth,
ratik21,
robert-zaremba,
rmeena840,
sczembor and
thdailong
Megha-Dev-19
force-pushed
the
web-multisig
branch
from
0875ff7 to
4b564b4
Compare
ratik21
reviewed
Oct 11, 2022
sczembor
reviewed
Oct 11, 2022
rmeena840
previously approved these changes
Oct 12, 2022
|
@Megha-Dev-19 Update changelog.md |
ratik21
approved these changes
Oct 12, 2022
As I said I don't think we can add the test for multisig using unit test because the wallet actually wait for the cosigner signature, and I don't think it is possible with unit test, it can done from the wallet UX only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multisig for MyAlgo Wallet