Make JUnitRunner Filterable #8
Conversation
| override def testCount() = suiteToRun.expectedTestCount(Filter()) | ||
|
|
||
| override def filter(filter: TestFilter): Unit = { | ||
| if (filter.shouldRun(getDescription)) throw new NoTestsRemainException |
There was a problem hiding this comment.
I think you need to negate the condition. Towards that end, is a test possible?
There was a problem hiding this comment.
You are right, my bad. I added a test to check the correct behavior
SergeKireev
force-pushed
the
junitrunner_filterable
branch
from
28db599 to
d940433
Compare
SergeKireev
force-pushed
the
junitrunner_filterable
branch
2 times, most recently
from
994e115 to
6982fad
Compare
|
@SergeKireev Sorry for attending late to this, The changes looks great and I think it will be really helpful if we can merge this. By any chance have you signed before Artima Inc. CLA: http://www.artima.com/cla/contributorsLicenseAgreement.pdf or for Corporate: http://www.artima.com/cla/corpContributorsLicenseAgreement.pdf Please kindly print, sign and scan back a copy to cla@artima.com, we apologize for any inconvenience caused, we intended to improve the process but somehow it just didn't happen yet. Thanks again for your hard effort! Cheers. |
|
@cla-bot[bot] check |
|
Hi @SergeKireev, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@SergeKireev Changes are merged in |
This would help solve pantsbuild/pants#8594, and make this runner coherent with runners in junit libraries