Skip to content

Add alter column type #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 8, 2025
Merged

Add alter column type #3028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c062e08
Add alter column type
KodaiD Sep 20, 2025
754d7ee
Merge branch 'master' into add-alter-column-type
KodaiD Sep 26, 2025
f1a935d
Fix
KodaiD Oct 2, 2025
3f2e875
Apply suggestions
KodaiD Oct 2, 2025
64fdf4f
Update integration tests
KodaiD Oct 2, 2025
e8c8ea6
Apply suggestions
KodaiD Oct 3, 2025
31c4876
Make primary or index key column type conversion not supported
KodaiD Oct 3, 2025
5feb5ce
Merge remote-tracking branch 'origin/master' into add-alter-column-type
KodaiD Oct 3, 2025
3f9e399
Apply suggestion
KodaiD Oct 6, 2025
d775440
Apply suggestion
KodaiD Oct 6, 2025
b41de5e
Update supported type conversion in Db2
KodaiD Oct 7, 2025
0724fc4
Apply suggestions
KodaiD Oct 7, 2025
776c08b
Fix unit test
KodaiD Oct 7, 2025
fc51ea1
Apply suggestions
KodaiD Oct 7, 2025
d70e5d7
Merge branch 'master' into add-alter-column-type
brfrn169 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...st/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions .../integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
5 changes: 5 additions & 0 deletions ...on-test/java/com/scalar/db/storage/cassandra/CassandraAdminPermissionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ public void renameColumn_WithSufficientPermission_ShouldSucceed() throws Executi
.doesNotThrowAnyException();
}

@Test
@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("Cassandra does not support renaming tables")
Expand Down
13 changes: 13 additions & 0 deletions ...ava/com/scalar/db/storage/cassandra/ConsensusCommitAdminIntegrationTestWithCassandra.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...db/storage/cassandra/SingleCrudOperationTransactionAdminIntegrationTestWithCassandra.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
}
}

@Override
@Disabled("Cassandra does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cassandra does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cassandra does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...test/java/com/scalar/db/storage/cosmos/ConsensusCommitAdminIntegrationTestWithCosmos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...ion-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...calar/db/storage/cosmos/SingleCrudOperationTransactionAdminIntegrationTestWithCosmos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("Cosmos DB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("Cosmos DB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("Cosmos DB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions ...ion-test/java/com/scalar/db/storage/dynamo/DynamoAdminCaseSensitivityIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
13 changes: 13 additions & 0 deletions core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
5 changes: 5 additions & 0 deletions ...egration-test/java/com/scalar/db/storage/dynamo/DynamoAdminPermissionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ public void dropColumnFromTable_WithSufficientPermission_ShouldSucceed() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}

@Test
@Override
@Disabled("DynamoDB does not support renaming tables")
Expand Down
13 changes: 13 additions & 0 deletions ...calar/db/storage/dynamo/SingleCrudOperationTransactionAdminIntegrationTestWithDynamo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
@Disabled("DynamoDB does not support renaming columns")
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}

@Override
@Disabled("DynamoDB does not support altering column types")
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}

@Override
@Disabled("DynamoDB does not support renaming tables")
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}
Expand Down
Loading