Skip to content

Commit 2cf23f1

Browse files
feeblefakieKodaiD
feeblefakie
and
KodaiD
authored
Backport to branch(3) : Add alter column type (#3038)
Co-authored-by: Kodai Doki <52027276+KodaiD@users.noreply.github.com> Co-authored-by: Kodai Doki <kodai.doki@scalar-labs.com>
1 parent c79ecc2 commit 2cf23f1

File tree

54 files changed

+3100
-59
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+3100
-59
lines changed

‎core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminCaseSensitivityIntegrationTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7373
}
7474
}
7575

76+
@Override
77+
@Disabled("Cassandra does not support altering column types")
78+
public void
79+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
80+
81+
@Override
82+
@Disabled("Cassandra does not support altering column types")
83+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
84+
85+
@Override
86+
@Disabled("Cassandra does not support altering column types")
87+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
88+
7689
@Override
7790
@Disabled("Cassandra does not support renaming tables")
7891
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminIntegrationTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7272
}
7373
}
7474

75+
@Override
76+
@Disabled("Cassandra does not support altering column types")
77+
public void
78+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
79+
80+
@Override
81+
@Disabled("Cassandra does not support altering column types")
82+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
83+
84+
@Override
85+
@Disabled("Cassandra does not support altering column types")
86+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
87+
7588
@Override
7689
@Disabled("Cassandra does not support renaming tables")
7790
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cassandra/CassandraAdminPermissionIntegrationTest.java‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@ public void renameColumn_WithSufficientPermission_ShouldSucceed() throws Executi
154154
.doesNotThrowAnyException();
155155
}
156156

157+
@Test
158+
@Override
159+
@Disabled("Cassandra does not support altering column types")
160+
public void alterColumnType_WithSufficientPermission_ShouldSucceed() {}
161+
157162
@Test
158163
@Override
159164
@Disabled("Cassandra does not support renaming tables")

‎core/src/integration-test/java/com/scalar/db/storage/cassandra/ConsensusCommitAdminIntegrationTestWithCassandra.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
9090
}
9191
}
9292

93+
@Override
94+
@Disabled("Cassandra does not support altering column types")
95+
public void
96+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
97+
98+
@Override
99+
@Disabled("Cassandra does not support altering column types")
100+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
101+
102+
@Override
103+
@Disabled("Cassandra does not support altering column types")
104+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
105+
93106
@Override
94107
@Disabled("Cassandra does not support renaming tables")
95108
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cassandra/SingleCrudOperationTransactionAdminIntegrationTestWithCassandra.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,19 @@ public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly()
7777
}
7878
}
7979

80+
@Override
81+
@Disabled("Cassandra does not support altering column types")
82+
public void
83+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
84+
85+
@Override
86+
@Disabled("Cassandra does not support altering column types")
87+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
88+
89+
@Override
90+
@Disabled("Cassandra does not support altering column types")
91+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
92+
8093
@Override
8194
@Disabled("Cassandra does not support renaming tables")
8295
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cosmos/ConsensusCommitAdminIntegrationTestWithCosmos.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
8585
@Disabled("Cosmos DB does not support renaming columns")
8686
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
8787

88+
@Override
89+
@Disabled("Cosmos DB does not support altering column types")
90+
public void
91+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
92+
93+
@Override
94+
@Disabled("Cosmos DB does not support altering column types")
95+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
96+
97+
@Override
98+
@Disabled("Cosmos DB does not support altering column types")
99+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
100+
88101
@Override
89102
@Disabled("Cosmos DB does not support renaming tables")
90103
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminCaseSensitivityIntegrationTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
7070
@Disabled("Cosmos DB does not support renaming columns")
7171
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7272

73+
@Override
74+
@Disabled("Cosmos DB does not support altering column types")
75+
public void
76+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
77+
78+
@Override
79+
@Disabled("Cosmos DB does not support altering column types")
80+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
81+
82+
@Override
83+
@Disabled("Cosmos DB does not support altering column types")
84+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
85+
7386
@Override
7487
@Disabled("Cosmos DB does not support renaming tables")
7588
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cosmos/CosmosAdminIntegrationTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
6969
@Disabled("Cosmos DB does not support renaming columns")
7070
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7171

72+
@Override
73+
@Disabled("Cosmos DB does not support altering column types")
74+
public void
75+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
76+
77+
@Override
78+
@Disabled("Cosmos DB does not support altering column types")
79+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
80+
81+
@Override
82+
@Disabled("Cosmos DB does not support altering column types")
83+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
84+
7285
@Override
7386
@Disabled("Cosmos DB does not support renaming tables")
7487
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/cosmos/SingleCrudOperationTransactionAdminIntegrationTestWithCosmos.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
7070
@Disabled("Cosmos DB does not support renaming columns")
7171
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
7272

73+
@Override
74+
@Disabled("Cosmos DB does not support altering column types")
75+
public void
76+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
77+
78+
@Override
79+
@Disabled("Cosmos DB does not support altering column types")
80+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
81+
82+
@Override
83+
@Disabled("Cosmos DB does not support altering column types")
84+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
85+
7386
@Override
7487
@Disabled("Cosmos DB does not support renaming tables")
7588
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

‎core/src/integration-test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,19 @@ public void renameColumn_ForPrimaryKeyColumn_ShouldRenameColumnCorrectly() {}
139139
@Disabled("DynamoDB does not support renaming columns")
140140
public void renameColumn_ForIndexKeyColumn_ShouldRenameColumnAndIndexCorrectly() {}
141141

142+
@Override
143+
@Disabled("DynamoDB does not support altering column types")
144+
public void
145+
alterColumnType_AlterColumnTypeFromEachExistingDataTypeToText_ShouldAlterColumnTypesCorrectly() {}
146+
147+
@Override
148+
@Disabled("DynamoDB does not support altering column types")
149+
public void alterColumnType_WideningConversion_ShouldAlterColumnTypesCorrectly() {}
150+
151+
@Override
152+
@Disabled("DynamoDB does not support altering column types")
153+
public void alterColumnType_ForPrimaryKeyOrIndexKeyColumn_ShouldThrowIllegalArgumentException() {}
154+
142155
@Override
143156
@Disabled("DynamoDB does not support renaming tables")
144157
public void renameTable_ForExistingTable_ShouldRenameTableCorrectly() {}

0 commit comments

Comments
 (0)