Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call asSymbol in fullJavaName #49

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Nov 2, 2015

if without this fix

https://travis-ci.org/xuwei-k/ScalaPB/jobs/88728473#L760
xuwei-k@a9a93d7e4d759e0

[error] /home/travis/build/xuwei-k/ScalaPB/e2e/target/scala-2.10/src_managed/main/compiled_protobuf/name_test/names/dot/yield.scala:38: identifier expected but 'yield' found.
[error] object `yield` extends com.trueaccord.scalapb.GeneratedMessageCompanion[`yield`] with com.trueaccord.scalapb.JavaProtoSupport[`yield`, name_test.NamesDot.yield]  {
[error]                                                                                                                                                           ^
[error] /home/travis/build/xuwei-k/ScalaPB/e2e/target/scala-2.10/src_managed/main/compiled_protobuf/name_test/names/dot/yield.scala:39: identifier expected but 'yield' found.
[error]   implicit def messageCompanion: com.trueaccord.scalapb.GeneratedMessageCompanion[`yield`] with com.trueaccord.scalapb.JavaProtoSupport[`yield`, name_test.NamesDot.yield]  = this
[error]                                                                                                                                                                     ^
[error] /home/travis/build/xuwei-k/ScalaPB/e2e/target/scala-2.10/src_managed/main/compiled_protobuf/name_test/names/dot/yield.scala:40: identifier expected but 'yield' found.
[error]   def toJavaProto(scalaPbSource: name_test.names.dot.`yield`): name_test.NamesDot.yield = {
[error]                                                                                   ^
[error] /home/travis/build/xuwei-k/ScalaPB/e2e/target/scala-2.10/src_managed/main/compiled_protobuf/name_test/names/dot/yield.scala:44: illegal start of simple expression
[error]   def fromJavaProto(javaPbSource: name_test.NamesDot.yield): name_test.names.dot.`yield` = name_test.names.dot.`yield`(
[error] ^
[error] /home/travis/build/xuwei-k/ScalaPB/e2e/target/scala-2.10/src_managed/main/compiled_protobuf/name_test/names/dot/yield.scala:44: identifier expected but 'yield' found.
[error]   def fromJavaProto(javaPbSource: name_test.NamesDot.yield): name_test.names.dot.`yield` = name_test.names.dot.`yield`(
[error]                                                      ^
[error] 5 errors found

thesamet added a commit that referenced this pull request Nov 2, 2015
@thesamet thesamet merged commit e07b284 into scalapb:master Nov 2, 2015
@xuwei-k xuwei-k deleted the fullJavaName-asSymbol branch November 2, 2015 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants