Another fix for verticalMultilineAtDefinitionSite
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where defaulted methods with called with () would get split.
olafurpg
approved these changes
Feb 3, 2017
| @@ -435,7 +435,8 @@ class Router(formatOps: FormatOps) { | |||
| val oneLinePerArg = OneArgOneLineSplit(open).f | |||
| val paramGroupSplitter: PartialFunction[Decision, Decision] = { | |||
| // Indent seperators `)(` by `indentSep` | |||
| case Decision(t @ FormatToken(_, rp @ RightParen(), _), _) => | |||
| case Decision(t @ FormatToken(_, rp @ RightParen(), _), _) | |||
| if rp == lastParen || !isCallSite(owners(rp)) => | |||
There was a problem hiding this comment.
I think owners (rp) == leftOwner should also work. For pathological cases, you could for example define a new method inside the default parameter value block.
There was a problem hiding this comment.
Good point, added a test and fixed it.
olafurpg
reviewed
Feb 3, 2017
| name: Name, | ||
| code: String = Defaults.code, | ||
| updatedAt: Instant = Instant.now(), | ||
| user: User = new User { def someFunc(): RT = () }, |
There was a problem hiding this comment.
I have btw seen crazy code like this! iirc it was somewhere in twitter/summingbird ^_^
There was a problem hiding this comment.
I can gladly say I've never seen this; wasn't even sure it would parse :\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another bug fix for
verticalMultilineAtDefinitionSite. I suspect this should be the last one though.Fixes an issue where
verticalMultilineAtDefinitionSitewould incorrectly split defaulted parameters that called a method.ie: