Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: check BOF/EOF when looking for LF #3278

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Rewrite: check BOF/EOF when looking for LF #3278

merged 2 commits into from
Jul 25, 2022

Conversation

kitbellew
Copy link
Collaborator

Fixes #3275.

@kitbellew
Rewrite: check BOF/EOF when looking for LF
f0a3d88 
This avoids an extra newline when an import statement starts the source.
tgodzik
tgodzik approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew kitbellew merged commit 654694f into scalameta:master Jul 25, 2022
@kitbellew kitbellew deleted the 3275 branch July 25, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@tanishiking tanishiking Awaiting requested review from tanishiking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpandImportSelectors add newline under the first import if there's no package
2 participants
@kitbellew @tgodzik