Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use js-native folder by sbt-crossproject #646

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Use js-native folder by sbt-crossproject #646

merged 1 commit into from
Apr 17, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Apr 15, 2023

Avoid creating extra Compile / unmanagedSourceDirectories for non-jvm

@lolgab
Use js-native folder by sbt-crossproject
c18f60b 
Avoid creating extra     `Compile / unmanagedSourceDirectories` for non-jvm
@lolgab lolgab marked this pull request as ready for review April 15, 2023 09:47
tgodzik
tgodzik approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@tgodzik tgodzik merged commit 29eeea4 into scalameta:main Apr 17, 2023
@lolgab lolgab deleted the js-native-sources branch April 17, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @tgodzik