Use correct parent classloader for worksheets. #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
force-pushed
the
worksheet-classpath
branch
from
029f9f6 to
8382d66
Compare
tgodzik
requested changes
Mar 25, 2021
metals/src/main/scala/scala/meta/internal/worksheets/WorksheetClassLoader.scala
Outdated
Show resolved
Hide resolved
|
Also, #2525 is probably related. |
Instead of passing in `null` when we extend ClassLoader in our MdocClassLoader this passes in the actual parent since on Java +9 when using `null` that's the bootstrap classloader which doesn't contain modules like java.sql. Big thanks to @smarter pointing this out in scala/scala3#11658. Fixes scalameta#2187
ckipp01
force-pushed
the
worksheet-classpath
branch
from
8382d66 to
cd1568b
Compare
Playing around with it a bit, this doesn't change that behavior at all, so I don't think it is, but could totally be wrong. |
The resources in akka are coming most likely from the classloader, which we change, so I thought it might be connected 🤔 I will take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing in
nullwhen we extend ClassLoader in ourMdocClassLoader this passes in the actual parent since on Java +9 when
using
nullthat's the bootstrap classloader which doesn't containmodules like java.sql.
Big thanks to @smarter pointing this out in scala/scala3#11658.
Fixes #2187