Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screen-record of Scaladoc auto-completion in v0.8.0 release-note. #1309

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

tanishiking
Copy link
Member

@tanishiking tanishiking commented Jan 15, 2020

This PR updates the screen-record of the Scaladoc auto-completion section in v0.8.0's release note.

The previous screen record came from the Pull Request, but it is a bit different from real behavior: we don't add * @constructor line for scaladoc on a class definition. Sorry for the confusion!
(the behavior had updated in cf8e607, but I didn't update the screen-record.)

before

scaladoc

after

scaladoc

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for fixing this :)

@gabro gabro merged commit c1102a1 into scalameta:master Jan 15, 2020
@tgodzik
Copy link
Contributor

tgodzik commented Jan 15, 2020

@tanishiking Thanks! I missed that!

@tanishiking tanishiking deleted the update-screen-record-scaladoc branch January 15, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants