Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish JsModifier for 2.13 #385

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Publish JsModifier for 2.13 #385

merged 2 commits into from
Sep 12, 2020

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Sep 12, 2020

I've noticed that JsModifier is not published for 2.13 - not sure what's the reason for that?

Published it locally and it works

@keynmol keynmol mentioned this pull request Sep 12, 2020
Merged
4 tasks
olafurpg
olafurpg approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! I can’t remember the exact reasoning behind the current build, maybe the linker wasn’t published for 2.13 🤔

@olafurpg olafurpg merged commit 377c36a into scalameta:master Sep 12, 2020
@keynmol keynmol deleted the js-modifier-2.13 branch September 12, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keynmol @olafurpg