-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 0.27.0-RC1 and drop pprint for Dotty #383
Conversation
0599f0a
to
f17f2a7
Compare
@@ -0,0 +1,15 @@ | |||
package mdoc.internal.sourcecode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macros are copied from sourcecode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cloned your fork, changed branch, then I am opening a VSCode, go to WorksheetSuite, run 'test'. All tests fail with:
error: basic.scala:9 (mdoc generated code) Symbol 'type mdoc.interfaces.RangePosition' is missing from the classpath.
This symbol is required by 'class mdoc.document.RangePosition'.
Make sure that type RangePosition is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
A full rebuild may help if 'RangePosition.class' was compiled against an incompatible version of mdoc.interfaces.
val x = 1.to(4).toVector; $doc.binder(x, 1, 4, 1, 5)
bloop test worksheets
<- same problem
tests/worksheets/src/test/scala/tests/worksheets/WorksheetSuite.scala
Outdated
Show resolved
Hide resolved
@@ -147,25 +177,26 @@ class WorksheetSuite extends BaseSuite { | |||
|
|||
// From 2.13 we get `name =` part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't get named params in case classes for dotty? Maybe comment need to change to 'For 2.13 only'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From discussions it turns out it causes a bit too verbose output and since we are not using pprint here, but toString named parameters are out. I will change the comment.
tests/worksheets/src/test/scala/tests/worksheets/WorksheetSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments but for a more meaningful review I think you need someone that also looked at adding dotty support because those changes are strongly based on that.
I can't really reproduce the issue. Best to change the version to a stable one before publishing. |
Maybe I am doing something wrong, but what ? ;/
Works perfectly fine with sbt Oo |
f17f2a7
to
2046711
Compare
Wait what? version of what? publishing of what? what has unstable version? ❓ |
2046711
to
4c0f3db
Compare
So the problem is that we need to publish for 0.27.0 and 2.12 some of the dependecies. Each time the scala version changes the dyn plugin generates a different version, so I am testing it under |
4c0f3db
to
6cbf101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok assuming it was checked in metals that dotty worksheets still work LGTM!
One thing we can improve now or later would be for newcomer wanting to contribute to explain to them what to do when they clone this repo, add test and cannot run it. (I would just update README.md with something like 'if you try to run tests and see this error "Symbol 'type mdoc.interfaces.RangePosition' is missing from the classpath" then execute this and it should work: '?????')
4b51a63
to
c58fe92
Compare
…printer an toString
c58fe92
to
89341cb
Compare
594dca1
to
9a10ccb
Compare
I will go ahead with the merge an release. @olafurpg If something at all breaks I will make sure it's fixed as quickly as possible, but hopefully there shouldn't be any problems since the changes to to the Scala 2 functionalities are really small. |
This PR does the following: