Skip to content

Make logging customizable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2019
Merged

Make logging customizable #1

merged 4 commits into from
Jul 31, 2019

Conversation

mzarnowski
Copy link

@mzarnowski mzarnowski commented Jul 23, 2019 •
edited
Loading

Currently all of the loggers are static. This makes them non-static and allows the users to customize them on creation.

@mzarnowski mzarnowski requested a review from jvican July 23, 2019 09:50
jvican
jvican approved these changes Jul 31, 2019
View reviewed changes
Copy link

@jvican jvican left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 This is great, thank you! It's really a pity that Java libraries use static loggers.

@jvican jvican merged commit 244576a into scalacenter:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzarnowski @jvican